Other income additional comments prefix for page 2 13614c #5620
Conversation
|
Heroku app: https://gyr-review-app-5620-8caad679cdd4.herokuapp.com/ |
…on-of-other-income-types-value-for-ty-2024
| @@ -29,7 +29,7 @@ def selected_orgs_and_sites | |||
| if model.instance_of? Site | |||
| model = available_by_id[model.parent_organization_id] | |||
| end | |||
| model.coalition_id == selected_model.id | |||
| model&.coalition_id == selected_model.id | |||
There was a problem hiding this comment.
unrelated to this ticket but noticed this will cause this page to crash sometimes; model is nil when can't find model on available_by_id[model.parent_organization_id]
| } | ||
| }); | ||
| }); | ||
| </script> |
There was a problem hiding this comment.
I see we have a label_and_field method which allows a prefix in honeycrisp that is used by cfa_textarea although cfa_textarea does not pass through a prefix option -- if that was an available option, would that have been a good solution to creating a prefix? Could we create a vita_min_textarea and then create a ticket to update honeycrisp to allow adding a prefix?
| @@ -391,7 +391,7 @@ | |||
|
|
|||
| expect(intake.cv_other_income_cb_yes?).to eq true | |||
|
|
|||
| expect(intake.cv_p2_notes_comments).to eq "Hello" | |||
| expect(intake.cv_p2_notes_comments).to eq "additional income from banana stand" | |||
There was a problem hiding this comment.
should we see "Other money received during the year includes:" text anywhere in the feature specs?
|
|
||
| textArea.addEventListener("input", function() { | ||
| if (!this.value.startsWith(prefix)) { | ||
| this.value = prefix + this.value.replace(prefix, ''); |
|
|
||
| textArea.form.addEventListener("submit", function() { | ||
| if (textArea.value.startsWith(prefix)) { | ||
| textArea.value = textArea.value.replace(prefix, '').trim(); |
There was a problem hiding this comment.
can textArea.value be nil? Or is it guaranteed to be ""?
| form = described_class.new(client, form_attributes) | ||
| form.save | ||
| intake.reload | ||
| end.to change(intake, :had_wages).to "yes" |
There was a problem hiding this comment.
how come had_wages is treated differently from all the other attributes?
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test? Heroku env
Screenshots (for visual changes)