[CCAP-509] adding additional counties behind enableSDA15Providers flag #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anahar-cfa
changed the title
analoo
reviewed
Feb 4, 2025
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.test.context.SpringBootTest; | ||
| import org.springframework.boot.test.util.TestPropertyValues; |
There was a problem hiding this comment.
@anahar-cfa - you are importing a lot of classes that are not used anywhere on the tests. Can you remove those?
Also - If you are testing that the number of active county options is 18 when the flag is on. It would make sense to also confirm that those inactive counties are NOT included when the feature flag is off.
analoo
reviewed
Feb 4, 2025
| countyOptions.add(MCHENRY); | ||
| countyOptions.add(OGLE); | ||
| countyOptions.add(WHITESIDE); | ||
| if (enableSDA15Providers) { |
There was a problem hiding this comment.
rather than hard coding this, I think it makes sense to use this logic:
public static Boolean isValidZipcodeOption(String zipcode, Boolean includeSDA15) {
return Arrays.stream(ZipcodeOption.values()).filter(zip -> zip.active)
.filter(zip -> includeSDA15 ? zip.caseloadCode.equals("BB") || zip.caseloadCode.equals("QQ")
: zip.caseloadCode.equals("BB")).anyMatch(zip -> zip.value.equals(zipcode));
}
to determine whether the county is valid or not.
We don't want the two sets of data to get our of sync.
analoo
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Jira ticket
✍️ Description
📷 Design reference
✅ Completion tasks