⚡️ Speed up function _get_url_for_version
by 29% in python_modules/dagster/dagster/_generate/download.py
#78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_get_url_for_version()
inpython_modules/dagster/dagster/_generate/download.py
📈 Performance improved by
29%
(0.29x
faster)⏱️ Runtime went down from
1.23 millisecond
to954 microseconds
Explanation and details
Here's an optimized version of the given program. The key improvement here is reducing the function call overhead by directly embedding
_get_target_for_version
logic within_get_url_for_version
.With this change.
_get_target_for_version
is optimized using a single return statement._get_url_for_version
is slightly optimized by inlining the logic, but it does explicitly keep the optimized_get_target_for_version
function for potential reuse elsewhere.Correctness verification
The new optimized code was tested for correctness. The results are listed below.
✅ 2 Passed − ⚙️ Existing Unit Tests
(click to show existing tests)
✅ 1014 Passed − 🌀 Generated Regression Tests
(click to show generated tests)
🔘 (none found) − ⏪ Replay Tests