added the circular progress bar #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsFlash10
reviewed
Nov 1, 2024
app/components/CourseCard.tsx
Outdated
| @@ -41,10 +41,9 @@ export const CourseCard = observer(function CourseCard(props: CourseCardProps) { | |||
| style={$image} | |||
| /> | |||
| <View style={$subContainer}> | |||
| <View> | |||
| <View style={{ flexDirection: 'row', alignItems: 'center', justifyContent: 'space-between' }}> | |||
There was a problem hiding this comment.
remove inline styling and use object-based styling as the other styles
ItsFlash10
reviewed
Nov 1, 2024
app/components/Progress.tsx
Outdated
| progress: number | ||
| /** an optional style override useful for padding & margin. */ | ||
| style?: StyleProp<ViewStyle> | ||
| // Packages Imports |
There was a problem hiding this comment.
Please make a different component for circular progress and keep this component intact, alternatively, you can make a preset in this component itself. Whatever suits best to you.
|
@ItsFlash10 I have made the said changes and pushed to the same branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a todo in CourseCard.tsx to add circular progress
here is a preview: