Trie #27
Merged
Trie #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about tests? |
code-shoily
reviewed
Oct 30, 2020
| List _split(V value) { | ||
| List<V> list = splitter(value); | ||
| for (var component in list) { | ||
| if (!components.contains(component)) throw ('$component ∉ $components'); |
There was a problem hiding this comment.
Try throwing an error object instead, easily shareable and testable.
|
Yeah, will implement tests in a bit. Wasn't sure about the splitter approach. Thanks for reviewing. |
happy-san
force-pushed
the
trie
branch
5 times, most recently
from
f913b97 to
620c424
Compare
code-shoily
approved these changes
Nov 2, 2020
test/trie/trie_test.dart
Outdated
| }); | ||
|
|
||
| test('Empty trie', () { | ||
| expect(emptyTrie.isEmpty, true); |
There was a problem hiding this comment.
Use isTrue and isFalse instead of true and false?
test/trie/trie_test.dart
Outdated
| expect(trie.components, | ||
| {...List.generate(26, (i) => String.fromCharCode(122 - i))}); | ||
|
|
||
| expect(customTrie.components, {'f', 'o', 'b', 'a', 'r', 'z'}); |
There was a problem hiding this comment.
expect(customTrie.components, equals({'f', 'o', 'b', 'a', 'r', 'z'}))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19 @code-shoily