fix: loop over forward slashes for relative dir, replace after urlencode #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
approved these changes
Jan 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v5.5.x #64 +/- ##
=========================================
Coverage 63.99% 63.99%
Complexity 1252 1252
=========================================
Files 53 53
Lines 3611 3611
=========================================
Hits 2311 2311
Misses 1300 1300 ☔ View full report in Codecov by Sentry. |
|
Update: I am a bit unsatisfied about the current code, maybe I will refactor it a bit before merging this |
| @@ -69,7 +69,7 @@ | |||
| <select class="form-control" id="version-switcher" name="version"> | |||
| {% for version in project.versions %} | |||
| <option | |||
| value="{{ path('../' ~ version|url_encode ~ '/index.html') }}" | |||
| value="{% for i in project.version|split('/') %}../{% endfor %}{{ path(version|url_encode|replace({ '%2F': '/' }) ~ '/index.html') }}" | |||
There was a problem hiding this comment.
I'd recommend making a new template function in PHP-land.
That means:
- You can unit test the function
- Templates are easier to read - these templates are already pretty complicated
- If this same thing needs to happen elsewhere, the same function can be reused
- It's easier to make readable functional code in PHP than templates (imo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #63