pkg/sql: SQL metrics with app_name and db_name labels #143203
Draft
+277
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, Agg metrics internally use btree to store the label set of metrics. But we are not actually using any of the btree specific features like range queries or ordered iteration. We are only adding, deleting, looking up exact keys and iterating over all the keys. A hash map based data structure is a better fit for this use case. This commit replaces the btree with an UnorderedCache. This UnorderedCache is configured with an LRU based eviction policy and sets a max size limit on the number of items stored in the cache. This will also help us manage the cardinality of the metrics. Release note: none
|
This change is |
This commit introduces a new SQLCounter type, a wrapper around the AggCounter from the aggmetric package. This metric type helps manage labels added to SQL metrics based on cluster settings. Two new cluster settings added: - sql.application_name_metrics.enabled - enables app_name label - sql.db_name_metrics.enabled - enables db_name label When enabled, these settings add 'app_name' and 'db_name' labels to SQL metrics of type SQLCounter, allowing tracking of metrics by application and database. This commit also implements the SetOnChange mechanism for these cluster settings, ensuring metrics are automatically redeclared with relevant labels when settings change. Epic: CRDB-43153 Jira: CRDB-48253 Release note: None
arjunmahishi
force-pushed
the
aggmetrics-lru_db-app-label
branch
from
8902542 to
3f0d854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The first commit in this PR will be merged as part of #142822. This PR has to be merged after the changes in #142822 are merged.
This commit introduces a new
SQLCountertype, a wrapper around theAggCounterfrom theaggmetricpackage. This metric type helps managelabels added to SQL metrics based on cluster settings.
Two new cluster settings added:
sql.application_name_metrics.enabled- enablesapp_namelabelsql.db_name_metrics.enabled- enablesdb_namelabelWhen enabled, these settings add
app_nameanddb_namelabels to SQLmetrics of type
SQLCounter, allowing tracking of metrics by applicationand database.
This commit also implements the
SetOnChangemechanism for these clustersettings, ensuring metrics are automatically redeclared with relevant
labels when settings change.
Epic: CRDB-43153
Jira: CRDB-48253
Release note: None