Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: kvserver: reset some fields of replicaAppBatch #143195

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 20, 2025

Backport 1/1 commits from #143191 on behalf of @pav-kv.

/cc @cockroachdb/release


This commit fixes a bug in replicaAppBatch initialization. Some fields were not reset, and would be carried across batches. For example, the changeTruncatesSideloadedFiles field, once set to true, would be true forever, and cause Pebble sync on every command application.

Epic: none
Release note: none


Release justification: performance bug fix

This commit fixes a bug in replicaAppBatch initialization. Some fields
were not reset, and would be carried across batches. For example, the
changeTruncatesSideloadedFiles field, once set to true, would be true
forever, and cause Pebble sync on every command application.

Epic: none
Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 20, 2025 12:15
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-143191 branch from 0ede6f8 to 59e7a03 Compare March 20, 2025 12:15
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 20, 2025
Copy link
Author

blathers-crl bot commented Mar 20, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

Sorry, something went wrong.

@blathers-crl blathers-crl bot requested a review from tbg March 20, 2025 12:15
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 20, 2025
Copy link
Author

blathers-crl bot commented Mar 20, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@tbg tbg requested review from kvoli and removed request for tbg March 20, 2025 12:25
@pav-kv pav-kv merged commit 82e0600 into release-23.2 Mar 21, 2025
5 of 6 checks passed
@pav-kv pav-kv deleted the blathers/backport-release-23.2-143191 branch March 21, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-23.2.23
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants