-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-25.1: roachtest: fix missing binary for TPC-C in multitenant upgrade test #143184
Merged
shubhamdhama
merged 1 commit into
release-25.1
from
blathers/backport-release-25.1-143055
Mar 26, 2025
Merged
release-25.1: roachtest: fix missing binary for TPC-C in multitenant upgrade test #143184
shubhamdhama
merged 1 commit into
release-25.1
from
blathers/backport-release-25.1-143055
Mar 26, 2025
+11
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading status checks…
Summary: In multitenant upgrade tests, the TPC-C workload may fail if the required binary is missing on a node. This issue can occur when no tenant is created on nodes with the previous binary version, and the workload attempts to run using that binary. A sample excerpt from the upgrade plan illustrates the process: ``` ├── start cluster at version "v23.2.20" (1) ├── wait for all nodes (:1-4) to acknowledge cluster version '23.2' on system tenant (2) ├── set cluster setting "storage.ingest_split.enabled" to 'false' on system tenant (3) ├── run "maybe create some tenants" (4) ├── upgrade cluster from "v23.2.20" to "v24.1.13" │ ├── prevent auto-upgrades on system tenant by setting `preserve_downgrade_option` (5) │ ├── upgrade nodes :1-4 from "v23.2.20" to "v24.1.13" │ │ ├── restart node 2 with binary version v24.1.13 (6) │ │ ├── restart node 1 with binary version v24.1.13 (7) │ │ ├── allow upgrade to happen on system tenant by resetting `preserve_downgrade_option` (8) │ │ ├── restart node 3 with binary version v24.1.13 (9) │ │ ├── restart node 4 with binary version v24.1.13 (10) │ │ └── run "run workload on tenants" (11) │ ├── run "run workload on tenants" (12) ``` Once all the nodes are upgraded (step 10), we enter the finalizing phase in step 11. Our cluster configuration would then look like this, ``` [mixed-version-test/11_run-run-workload-on-tenants] 2025/03/13 10:47:21 runner.go:423: current cluster configuration: n1 n2 n3 n4 released versions v24.1.13 v24.1.13 v24.1.13 v24.1.13 binary versions 24.1 24.1 24.1 24.1 cluster versions 24.1 24.1 24.1 24.1 ``` This implies that our tenant would also start with the target version as we finalize (see #138233). Then we run the TPC-C workload on tenant nodes using the version we are migrating from—likely for compatibility reasons. However, the required binary may be absent if, during step 4, we did not create any tenants with the previous version due to probabilistic selection. The fix is simple: upload the binary used to run TPC-C. The process first checks whether the binary is already present, so no extra performance overhead occurs if it is. Fixes: #140507 Informs: #142807 Release note: None Epic: None
923d8b7
to
48b9205
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
cthumuluru-crdb
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
backport-test-only
Used to denote the backport has only non-production changes
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
target-release-25.1.4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #143055 on behalf of @shubhamdhama.
/cc @cockroachdb/release
Fixes: #142807
Summary: In multitenant upgrade tests, the TPC-C workload may fail if the required binary is missing on a node. This issue can occur when no tenant is created on nodes with the previous binary version, and the workload attempts to run using that binary.
A sample excerpt from the upgrade plan illustrates the process:
Once all the nodes are upgraded (step 10), we enter the finalizing phase in step 11. Our cluster configuration would then look like this,
This implies that our tenant would also start with the target version as we finalize (see #138233). Then we run the TPC-C workload on tenant nodes using the version we are migrating from—likely for compatibility reasons. However, the required binary may be absent if, during step 4, we did not create any tenants with the previous version due to probabilistic selection. The fix is simple: upload the binary used to run TPC-C. The process first checks whether the binary is already present, so no extra performance overhead occurs if it is.
Fixes: #140507
Release note: None
Epic: None
Release justification: Low risk roachtest fix