sql: only re-use resolved routine type when flag is set #143170
+50
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrewKimball
added
backport-24.1.x
|
This change is |
yuzefovich
added
backport-24.3.9-rc
mgartner
reviewed
Mar 24, 2025
| // should reuse the already resolved type, if any. This is used to handle | ||
| // "re-type-checking" that occurs for a RECORD-returning routine, for which | ||
| // the return type is not known until the routine body is built. | ||
| RoutineUseResolvedType bool |
There was a problem hiding this comment.
Does it make sense to use ScalarAncestors here? The special case is a bit confusing to me - it only applies to routines within a VALUES expression?
There was a problem hiding this comment.
I don't think we can use ScalarAncestors, or at least it would potentially be more confusing. We apply the special case to expressions within a VALUES operator, but only on the second type-checking pass which happens when the VALUES column type depends on a record-returning routine. Using ScalarAncestors here would cause us to to also use this special behavior on the first type-checking pass.
This commit adds a `RoutineUseResolvedType` flag to the `SemaContext` properties to indicate that type-checking for a routine that has already been resolved to a concrete type should short-circuit. This is used to determine the column type for a `Values` operator which depends on a RECORD-returning routine, which only determines its type after the body is built. This will prevent regressions in other code paths that do not desire this short-circuiting behavior. Fixes cockroachdb#142615 Release note (bug fix): Fixed a bug in `v24.1.14`, `v24.3.7`, `v24.3.8`, and `v25.1` which could cause a nil-pointer error when a column's default expression contained a volatile expression (like `nextval`) as a UDF argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
RoutineUseResolvedTypeflag to theSemaContextproperties to indicate that type-checking for a routine that has already been resolved to a concrete type should short-circuit. This is used to determine the column type for aValuesoperator which depends on a RECORD-returning routine, which only determines its type after the body is built. This will prevent regressions in other code paths that do not desire this short-circuiting behavior.Fixes #142615
Release note (bug fix): Fixed a bug in
v24.1.14,v24.3.7,v24.3.8, andv25.1which could cause a nil-pointer error when a column's default expression contained a volatile expression (likenextval) as a UDF argument.