-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-24.3: sql: don't disable streamer due to scanBufferNode #143166
Merged
yuzefovich
merged 1 commit into
release-24.3
from
blathers/backport-release-24.3-143151
Mar 24, 2025
Merged
release-24.3: sql: don't disable streamer due to scanBufferNode #143166
yuzefovich
merged 1 commit into
release-24.3
from
blathers/backport-release-24.3-143151
Mar 24, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
450e059
to
809274b
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
809274b
to
0b26b4b
Compare
In ed3f640 we disabled the streamer whenever the plan contains LocalPlanNode processor (which is just a wrapper around a `planNode`). This was done to prevent misuse of the txn API, and we knew at the time that we were disabling the streamer in more cases than strictly necessary. We just saw a support case where it was disabled due to `scanBufferNode`, so this commit includes `scanBufferNode` and `bufferNode` into the allow-list of planNodes that don't disable the streamer (since these don't interact with internal executors or the txn in any way). Also add a few trace messages around this code. Release note: None
0b26b4b
to
47533a2
Compare
mgartner
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
target-release-24.3.10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #143151 on behalf of @yuzefovich.
/cc @cockroachdb/release
In ed3f640 we disabled the streamer
whenever the plan contains LocalPlanNode processor (which is just
a wrapper around a
planNode
). This was done to prevent misuse of thetxn API, and we knew at the time that we were disabling the streamer in
more cases than strictly necessary. We just saw a support case where it
was disabled due to
scanBufferNode
, so this commit includesscanBufferNode
andbufferNode
into the allow-list of planNodes thatdon't disable the streamer (since these don't interact with internal
executors or the txn in any way).
Also add a few trace messages around this code.
Epic: None
Release note: None
Release justification: low-risk improvement.