Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix TestListProfilerExecutionDetails #143113

Merged

Conversation

shubhamdhama
Copy link
Contributor

In #142391, a bug was introduced in the test where testutils.SucceedSoon's closure used require.Len instead of returning an error, causing the test to fail if slice length doesn't match without retrying. This assertion has been reverted to the if statement that returns an error instead.

Fixes: #143082
Release note: none
Epic: none

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
In cockroachdb#142391, a bug was introduced in the test where
`testutils.SucceedSoon`'s closure used `require.Len` instead of returning
an error, causing the test to fail if slice length doesn't match without
retrying. This assertion has been reverted to the `if` statement that
returns an error instead.

Fixes: cockroachdb#143082
Release note: none
Epic: none
@shubhamdhama shubhamdhama requested a review from yuzefovich March 19, 2025 06:02
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Thanks!

bors r=yuzefovich

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cthumuluru-crdb)

@craig craig bot merged commit 7c38217 into cockroachdb:master Mar 19, 2025
24 checks passed
@shubhamdhama
Copy link
Contributor Author

TFT Review and Merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: TestListProfilerExecutionDetails failed
3 participants