Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-25.1: logictestccl: deflake as_of #143105

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 18, 2025

Backport 1/1 commits from #143008 on behalf of @annrpom.

/cc @cockroachdb/release


Epic: none

Fixes: #142325
Fixes: #142327

Release note: None


Release justification: test-only change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Epic: none

Fixes: #142325
Fixes: #142327

Release note: None
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-25.1-143008 branch from 8de9d4a to a0e068c Compare March 18, 2025 23:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 18, 2025
Copy link
Author

blathers-crl bot commented Mar 18, 2025

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

Sorry, something went wrong.

@blathers-crl blathers-crl bot requested a review from rafiss March 18, 2025 23:17
@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Mar 18, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@blathers-crl blathers-crl bot added the backport-test-only Used to denote the backport has only non-production changes label Mar 18, 2025
@rafiss rafiss merged commit 1a53844 into release-25.1 Mar 19, 2025
15 of 16 checks passed
@rafiss rafiss deleted the blathers/backport-release-25.1-143008 branch March 19, 2025 15:58
@yuzefovich
Copy link
Member

blathers backport release-25.1.3-rc

Copy link
Author

blathers-crl bot commented Mar 20, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting assignees, but backport branch blathers/backport-release-25.1.3-rc-143105 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/issues/143218/assignees: 404 Not Found []

Backport to branch release-25.1.3-rc failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches backport-failed backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. target-release-25.1.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants