changefeedccl: ensure that spans planned from cdc queries have end keys #143102
Conversation
|
This change is |
asg0451
force-pushed
the
fix-cdcquery-single-key-scan
branch
from
51a8b45 to
64602ec
Compare
asg0451
force-pushed
the
fix-cdcquery-single-key-scan
branch
from
64602ec to
cab9aa8
Compare
asg0451
added
the
backport-all
asg0451
force-pushed
the
fix-cdcquery-single-key-scan
branch
2 times, most recently
from
07b04c9 to
7ab5371
Compare
|
bors r=rharding6373,andyyang890 |
143102: changefeedccl: ensure that spans planned from cdc queries have end keys r=rharding6373,andyyang890 a=asg0451 When a cdc query results in a plan that scans a single key, the end key of the span is unset. This causes the feed to fail on startup. We now set span.EndKey = span.Key.Next(). Fixes: #143101 Release note (bug fix): Fixed a bug that caused feeds to fail on startup when scanning a single key. Co-authored-by: Miles Frankel <[email protected]>
|
bors cancel |
|
Canceled. |
asg0451
force-pushed
the
fix-cdcquery-single-key-scan
branch
from
7ab5371 to
7b0c306
Compare
|
bors r=rharding6373,andyyang890 |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
bors r=rharding6373,andyyang890 |
143102: changefeedccl: ensure that spans planned from cdc queries have end keys r=rharding6373,andyyang890 a=asg0451 When a cdc query results in a plan that scans a single key, the end key of the span is unset. This causes the feed to fail on startup. We now set span.EndKey = span.Key.Next(). Fixes: #143101 Release note (bug fix): Fixed a bug that caused feeds to fail on startup when scanning a single key. Co-authored-by: Miles Frankel <[email protected]>
|
bors cancel |
|
Canceled. |
When a cdc query results in a plan that scans a single key, the end key of the span is unset. This causes the feed to fail on startup. We now set span.EndKey = span.Key.Next(). Fixes: cockroachdb#143101 Release note (bug fix): Fixed a bug that caused feeds to fail on startup when scanning a single key.
asg0451
force-pushed
the
fix-cdcquery-single-key-scan
branch
from
7b0c306 to
adb564a
Compare
|
bors r=rharding6373,andyyang890 |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from adb564a to blathers/backport-release-23.2-143102: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-23.2 failed. See errors above. error creating merge commit from adb564a to blathers/backport-release-24.1-143102: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.1 failed. See errors above. error creating merge commit from adb564a to blathers/backport-release-24.3-143102: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-24.3 failed. See errors above. error creating merge commit from adb564a to blathers/backport-release-25.1-143102: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch release-25.1 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
When a cdc query results in a plan that scans a
single key, the end key of the span is unset. This
causes the feed to fail on startup. We now set
span.EndKey = span.Key.Next().
Fixes: #143101
Release note (bug fix): Fixed a bug that caused feeds to fail on startup when
scanning a single key.