Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracing,execinfrapb: include child metadata in trace agg metas #143090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dt
Copy link
Member

@dt dt commented Mar 18, 2025

This captures and includes in aggregated trace info the "child span metadata", i.e. the occurrence count count and sum duration of each uniquely named child span. These are included in the "per-component" and "cluster wide" trace dumps utilized by various jobs' advance debugging tools.

Release note: none.
Epic: none.

@dt dt requested a review from msbutler March 18, 2025 20:38
@dt dt requested review from a team as code owners March 18, 2025 20:38
@dt dt requested review from angles-n-daemons, arjunmahishi, aa-joshi and Abhinav1299 and removed request for a team March 18, 2025 20:38
Copy link

blathers-crl bot commented Mar 18, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@dt dt requested review from mw5h and removed request for a team March 18, 2025 20:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants