Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update hyperloglog to v0.2.5 #143087

Merged
merged 1 commit into from
Mar 20, 2025

Conversation

mgartner
Copy link
Collaborator

The hyperloglog library has been upgraded from v0.2.0 to v0.2.5. See the
commits in this upgrade here:
axiomhq/hyperloglog@v0.2.0...v0.2.5

Fixes #140772

Release note: None

@mgartner mgartner requested review from yuzefovich and a team March 18, 2025 20:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mgartner mgartner added the o-perf-efficiency Related to performance efficiency label Mar 18, 2025
@mgartner mgartner force-pushed the 140772-upgrade-hyperloglog branch from 38d83a3 to b5e6732 Compare March 18, 2025 20:35
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mgartner)

@mgartner mgartner force-pushed the 140772-upgrade-hyperloglog branch from b5e6732 to f8fb250 Compare March 18, 2025 22:39
@mgartner mgartner requested a review from a team as a code owner March 18, 2025 22:39
The hyperloglog library has been upgraded from v0.2.0 to v0.2.5. See the
commits in this upgrade here:
axiomhq/hyperloglog@v0.2.0...v0.2.5

Fixes cockroachdb#140772

Release note: None
@mgartner mgartner force-pushed the 140772-upgrade-hyperloglog branch from f8fb250 to 2d300f0 Compare March 19, 2025 23:15
Copy link
Collaborator

@rickystewart rickystewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this passes CI

@mgartner
Copy link
Collaborator Author

TFTRs and the assistance!

bors r+

@craig craig bot merged commit 4a3288f into cockroachdb:master Mar 20, 2025
24 checks passed
@mgartner mgartner deleted the 140772-upgrade-hyperloglog branch March 20, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
o-perf-efficiency Related to performance efficiency target-release-25.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stats: reduce overhead of distinct estimation
4 participants