cli: add locality-advertise-addr cli flag to mt start-sql command #143051
+306
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locality-advertise-addr cli flag was disabled to mt start-sql command. We are adding this flag now, to enable sql instances have locality aware addresses which can be used by sqlInstanceDialer in the sql server process. In order to add this, we eliminated the if condition which was wrapping the addition of this cli flag to the mtStartSQLCmd. Epic: CRDB-46923 Fixes: cockroachdb#138715 Part of: CRDB-46312 Release note: None
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
shaikzakiriitm
force-pushed
the
issue_138715
branch
from
18fcf03 to
aeb460f
Compare
…m.sql_instances table sql_instances table didn't have a way to store locality aware addresses for a sql instance which gets bootstrapped. Locality aware addresses will be used when dialing into a specific sql instance by the sqlInstanceDialer. This helps in routing the distributed sql query to the appropriate locality based address of a selected sql instance. As part of this change, added a column `locality_aware_address_list` of type jsonb into the sql_instances table. Also added version gate, and a migration upgrade for adding this new column. Included some unit tests around the same, testing addition of new column in the table. Epic: CRDB-46923 Fixes: cockroachdb#138715 Part of: CRDB-46312 Release note: None
shaikzakiriitm
force-pushed
the
issue_138715
branch
from
aeb460f to
e15bb40
Compare
|
Based on the comment here, this may not be immediately needed for external shared tenants. We can choose to defer these changes and track it using a backlog. I think it is also okay to commit these changes since the whole |
…ess_list column sql_instances table didn't capture list of locality addresses that can be used to dial the instance. Needed to add this column in order to persist locality addresses for a sql_instance, in order to unify sqlInstanceDialer initialization for both system and application tenants. With this unification, we don't need to depend on gossip layer to identify locality addresses to dial into system/shared tenants. As part of this commit, added logic to encode/decode locality_address_list column in sql_instances table. Epic: CRDB-46923 Fixes: cockroachdb#138715 Part of: CRDB-46312 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cli: add locality-advertise-addr cli flag to
./cockroach mt start-sqlcommandlocality-advertise-addr cli flag was disabled to mt start-sql command. We are adding this flag now, to enable sql instances have locality aware addresses which can be used by sqlInstanceDialer in the sql server process. In order to add this, we eliminated the if condition which was wrapping the addition of this cli flag to the mtStartSQLCmd.
Epic: CRDB-46923
Fixes: #138715
Part of: CRDB-46312
Release note: None