Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlstats: set session meta fields directly on sqlstats.RecordedTxnStats #143027

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

xinhaoz
Copy link
Member

@xinhaoz xinhaoz commented Mar 17, 2025

This commit replaces the SessionData pointer field on sqlstas.RecordedTxnStats with direct Application and UserNormalized fields for simpler access to session metadata.

Epic: none
Release note: None

@xinhaoz xinhaoz requested a review from a team as a code owner March 17, 2025 22:38
@xinhaoz xinhaoz requested review from alyshanjahani-crl and removed request for a team March 17, 2025 22:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@xinhaoz xinhaoz force-pushed the txn-stats-session-info branch from e1e98f4 to 66de092 Compare March 17, 2025 22:52
@xinhaoz xinhaoz changed the title sqlstats: session meta fields directly on sqlstats.RecordedTxnStats sqlstats: set session meta fields directly on sqlstats.RecordedTxnStats Mar 17, 2025
@xinhaoz xinhaoz force-pushed the txn-stats-session-info branch from 66de092 to a6d13e3 Compare March 17, 2025 22:55
@xinhaoz xinhaoz requested a review from a team March 18, 2025 14:47
Copy link
Collaborator

@alyshanjahani-crl alyshanjahani-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This commit replaces the SessionData pointer field on
sqlstas.RecordedTxnStats with direct Application and
UserNormalized fields for simpler access to session
metadata.

Epic: none
Release note: None
@xinhaoz xinhaoz force-pushed the txn-stats-session-info branch from a6d13e3 to 6bf8615 Compare March 18, 2025 18:52
@xinhaoz
Copy link
Member Author

xinhaoz commented Mar 18, 2025

TFTR!
bors r+

@craig craig bot merged commit 879f32a into cockroachdb:master Mar 18, 2025
23 of 24 checks passed
@xinhaoz xinhaoz deleted the txn-stats-session-info branch March 18, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants