sql: enable tenant testing for zone tests #141735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
shubhamdhama
commented
Feb 19, 2025
shubhamdhama
changed the title
zone_config_test
shubhamdhama
changed the title
Updating `TestValidSetShowZones` to use `createTestServerParamsAllowTenants` instead of `createTestServerParams` required some investigation. It turned out simpler than expected. Zone settings for meta ranges aren't supported for secondary tenants, so this change simply exclude them from setup and validating. Informs: cockroachdb#140446 Epic: CRDB-38970 Release note: None
Since `GetSpanConfigForKey` is only available in system tenant, it is not used when running under secondary tenants.
shubhamdhama
force-pushed
the
sql-tenant-testing-zone-config-tests
branch
from
c922210 to
344c262
Compare
rafiss
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
lgtm! thank you
Reviewable status:
complete! 0 of 0 LGTMs obtained
|
TFTR! bors r=rafiss |
craig bot
pushed a commit
that referenced
this pull request
Mar 13, 2025
141735: sql: enable tenant testing for zone tests r=rafiss a=shubhamdhama `` sql: enable tenant testing for `zone_test.go` `` Updating `TestValidSetShowZones` to use `createTestServerParamsAllowTenants` instead of `createTestServerParams` required some investigation. It turned out simpler than expected. Zone settings for meta ranges aren't supported for secondary tenants, so this change simply exclude them from setup and validating. Informs: #140446 Epic: CRDB-48357 Release note: None `` sql: enable tenant testing for `zone_config_test` `` Since `GetSpanConfigForKey` is only available in system tenant, it is not used when running under secondary tenants. 142186: kvserver: mark replica as unavailable if leaderless for a long time r=iskettaneh a=iskettaneh This PR marks the replica as unavailable in if it has been leaderless for a duration above: `kv.replica_raft.leaderless_unavailable_threshold`. This helps requests to bail early on unavailable ranges without relying on the replica circuit breaker to trip. This has multiple benefits: 1) Faster reaction time than the replica circuit breaker: If two nodes fail (assuming R=3), many ranges will become unavailable. With the replica circuit breaker, a scan query will need to trip the circuit breaker for multiple replicas, causing added delays. However, with this approach, the replica will basically become unavailable on the tick path (rather than on the request path). Meaning that a scan query wouldn't need to trip one circuit breaker after the other. 2) Lighter weight: Instead of relying on the replica circuit breaker to test the replication pipeline before it marks the range as available again, this approach relies on the Raft signal to know when there is a leader again, indicating that the range is available again. 3) With leader leases, a replica won't propose a lease if it's not the leader. This means that with leader leases, the replica circuit breaker might not trip if the range have lost quorum. However, with this commit, the replica will eventually forget who the leader was, and eventually the leaderlessWatcher would mark it as unavailable. Fixes: #139638 Release note: None 142489: row, sql: implement mutations on vector indexes r=mw5h a=mw5h This patch plumbs the output of the vector search operators into rowenc for encoding into vector indexes. The output of these vector search operators is included in the row values for mutation operators after partial index values and are plumbed into a new vector index update helper, which tracks the column values until they're needed by rowenc. While we're here, we homogonize how pkg/sql/{delete,insert,update,upsert}.go consume row values, hopefully improving legibility. Epic: CRDB-42943 Release note: None 142829: sql/catalog: fix object renames for PCR reader catalogs r=fqazi a=fqazi Previously, the PCR reader catalog would only delete namespace entries for a descriptor if it was not modified. This meant the reader catalog logic could leave behind stale entries in the system.namespace table after a object was renamed. To address this, this patch detects if an object is renamed, and allows the old namespace entry to be deleted. Fixes: #142828 Release note (bug fix): PCR reader catalogs could have orphan rows in system.namespace after a object is renamed. 142836: kvserver: deflake TestLeasePreferencesDuringOutage r=kvoli a=arulajmani There was a race here, when heartbeating node liveness epochs, where another node could increment our epoch. This patch retries in such situations. Fixes #142795 Release note: None Co-authored-by: Shubham Dhama <[email protected]> Co-authored-by: Ibrahim Kettaneh <[email protected]> Co-authored-by: Matt White <[email protected]> Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Arul Ajmani <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sql: enable tenant testing for `zone_test.go`Updating
TestValidSetShowZonesto usecreateTestServerParamsAllowTenantsinstead ofcreateTestServerParamsrequired some investigation. It turned out simpler than expected. Zone
settings for meta ranges aren't supported for secondary tenants, so this
change simply exclude them from setup and validating.
Informs: #140446
Epic: CRDB-48357
Release note: None
sql: enable tenant testing for `zone_config_test`Since
GetSpanConfigForKeyis only available in system tenant, it is notused when running under secondary tenants.