sql: increase tenant testing coverage

[shubhamdhama]

This PR continues the work from #140447, replacing occurrences of
createTestServerParams with createTestServerParamsAllowTenants
to enable tenant testing in these tests.

Informs: #140446
Epic: CRDB-38970
Release note: None

[cockroach-teamcity]

This change is 

[rafiss]

the pkg/sql changes lgtm, but some of these tests are owned by the SQL Queries and DR teams, so they should take a look.

[yuzefovich]

2nd commit

Reviewed 15 of 15 files at r1, 16 of 16 files at r2, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @DarrylWong, @golgeek, @kev-cao, @kyle-a-wong, @mgartner, and @wenyihu6)

[github-actions]

⚪ Sysbench [SQL, 3node, oltp_read_write]

Metric	Old Commit	New Commit	Delta	Note	Threshold
⚪ sec/op	9.640m ±2%	9.690m ±3%	~	p=0.684 n=10	3.0%
⚪ errs/op	0.000 ±0%	0.000 ±0%	~	p=1.000 n=10	0.0%
⚪ allocs/op	10.16k ±1%	10.15k ±0%	~	p=0.470 n=10	2.0%
⚪ B/op	2.182Mi ±0%	2.181Mi ±0%	~	p=0.971 n=10	2.0%

Reproduce

benchdiff binaries:

mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=fbcabe0 --new=6f2435c ./pkg/sql/tests

⚪ Sysbench [KV, 1node, local, oltp_read_only]

Metric	Old Commit	New Commit	Delta	Note	Threshold
⚪ sec/op	672.5µ ±1%	679.5µ ±2%	~	p=0.315 n=10	2.0%
⚪ errs/op	0.000 ±0%	0.000 ±0%	~	p=1.000 n=10	0.0%
⚪ allocs/op	439.0 ±0%	439.0 ±0%	~	p=1.000 n=10	1.5%
⚪ B/op	254.2Ki ±0%	254.2Ki ±0%	~	p=0.210 n=10	1.5%

Reproduce

benchdiff binaries:

mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_read_only$ --old=fbcabe0 --new=6f2435c ./pkg/sql/tests

⚪ Sysbench [KV, 1node, local, oltp_write_only]

Metric	Old Commit	New Commit	Delta	Note	Threshold
⚪ sec/op	1.338m ±1%	1.341m ±1%	~	p=0.684 n=10	2.5%
⚪ errs/op	0.000 ±0%	0.000 ±0%	~	p=1.000 n=10	0.0%
⚪ allocs/op	1.394k ±0%	1.394k ±0%	~	p=0.469 n=10	1.8%
⚪ B/op	290.3Ki ±0%	290.1Ki ±0%	~	p=0.436 n=10	1.8%

Reproduce

benchdiff binaries:

mkdir -p benchdiff/6f2435c/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/bin/pkg_sql_tests benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/6f2435c/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/fbcabe0/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/fbcabe029eb2e1701710d08cebbca6d15089f911/bin/pkg_sql_tests benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/fbcabe0/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/1node_local/oltp_write_only$ --old=fbcabe0 --new=6f2435c ./pkg/sql/tests

Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/6f2435c712e4ca5c7b72293bfb605a1f70bb998d/13456892060-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/fbcabe029eb2e1701710d08cebbca6d15089f911/13456892060-1/\* old/

Legend

• ⚪ Neutral: No significant performance change.
• 🟡 Warning: Slight degradation, likely due to variance, but still within thresholds.
• 🔴 Regression: Likely performance regression, requiring investigation.
• 🟢 Improvement: Possible performance gain.

No regressions detected!

built with commit: 6f2435c712e4ca5c7b72293bfb605a1f70bb998d

[shubhamdhama]

After removing the stacked commit, it seems there are no remaining changes that would affect the DR team. So, we should be good to merge. Thanks for the reviews!

bors r =rafiss,yuzefovich

[shubhamdhama]

Oops!

bors r=rafiss,yuzefovich

[craig]

Build succeeded:

• linux_amd64_build
• acceptance
• unit_tests
• local_roachtest
• examples_orms
• check_generated_code
• lint
• linux_amd64_fips_build
• docker_image_amd64
• local_roachtest_fips