testutils: add DeploymentMode method to ApplicationLayerInterface
#140662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdhama
requested review from
herkolategan,
srosenberg and
stevendanna
and removed request for
a team
|
This change is |
shubhamdhama
force-pushed
the
add-api-to-app-interface
branch
from
ce5e18d to
45c898b
Compare
stevendanna
reviewed
Feb 7, 2025
| @@ -910,6 +910,9 @@ type testTenant struct { | |||
| // pgPreServer handles SQL connections prior to routing them to a | |||
| // specific tenant. | |||
| pgPreServer *pgwire.PreServeConnHandler | |||
| // deploymentMode specifies the tenant's deployment mode. | |||
| // Allowed values: ExternalProcess or SharedProcess. | |||
There was a problem hiding this comment.
The allowed value list is a bit off. Doesn't include: SingleTenant
There was a problem hiding this comment.
IIUC, testTenant and testServer implement ApplicationInterface, with testTenant used for secondary tenants and testServer for a single tenant. That's why I didn't include SingleTenant here.
shubhamdhama
force-pushed
the
add-api-to-app-interface
branch
2 times, most recently
from
1493dc9 to
46fdfca
Compare
Certain tests need to determine the deployment mode of the test server—whether it's single-tenant, shared-process, or external-process. While this can be queried via SQL, a dedicated helper method improves usability. This commit adds `DeploymentMode` to `ApplicationLayerInterface` to provide a simpler way to retrieve this information. Informs: cockroachdb#138912 Epic: CRDB-38970 Release note: None
shubhamdhama
force-pushed
the
add-api-to-app-interface
branch
from
46fdfca to
9413682
Compare
stevendanna
approved these changes
Feb 13, 2025
herkolategan
approved these changes
Feb 13, 2025
|
Thanks for the reviews! bors r=stevendanna,herkolategan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain tests need to determine the deployment mode of the test
server—whether it's single-tenant, shared-process, or external-process.
While this can be queried via SQL, a dedicated helper method improves
usability.
This commit adds
DeploymentModetoApplicationLayerInterfaceto providea simpler way to retrieve this information.
Informs: #138912
Epic: CRDB-38970
Release note: None