Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backup: remove TODOTestTenantDisabled for tests #139846

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shubhamdhama
Copy link
Contributor

This change is part of our effort to eliminate the remaining usages of
TODOTestTenantDisabled from tests across various features. It removes
its occurrence in the backup tests.

Informs: #138912

Epic: CRDB-38970

Release note: None

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This change is part of our effort to eliminate the remaining usages of
`TODOTestTenantDisabled` from tests across various features. It removes
its occurrence in the backup tests.

Informs: cockroachdb#138912

Epic: CRDB-38970

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

DefaultTestTenant: base.TODOTestTenantDisabled,
},
}
args := base.TestClusterArgs{ServerArgs: base.TestServerArgs{}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was zero to almost no effort in enabling tenant testing for most of them, but not that straightforward to do that for TestExportRequestBelowGCThresholdOnDataExcludedFromBackup and TestExcludeDataFromBackupDoesNotHoldupGC. They fail because backpressure doesn't build up in upsertUntilBackpressure. Steven and I took a high level look and maybe the reason it doesn't build-up here is secondary tenant's spans are not included in backpressure checks:

// backpressurableSpans contains spans of keys where write backpressuring
// is permitted. Writes to any keys within these spans may cause a batch
// to be backpressured.
var backpressurableSpans = []roachpb.Span{
{Key: keys.TimeseriesPrefix, EndKey: keys.TimeseriesKeyMax},
// Backpressure from the end of the system config forward instead of
// over all table data to avoid backpressuring unsplittable ranges.
{Key: keys.SystemConfigTableDataMax, EndKey: keys.TableDataMax},
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants