Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestListProfilerExecutionDetails failed #143082

Closed
cockroach-teamcity opened this issue Mar 18, 2025 · 6 comments · Fixed by #143113
Closed

sql: TestListProfilerExecutionDetails failed #143082

cockroach-teamcity opened this issue Mar 18, 2025 · 6 comments · Fixed by #143113
Assignees
@shubhamdhama
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-db-server target-release-25.2.0

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 18, 2025 •
edited by cockroach-jira-scripts
Loading

sql.TestListProfilerExecutionDetails failed with artifacts on master @ c5964d7e54c7156e4813183bea5abdaad68f61a1:

=== RUN   TestListProfilerExecutionDetails
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails3089870620
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:141: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    jobs_profiler_execution_details_test.go:440: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails3089870620
--- FAIL: TestListProfilerExecutionDetails (1.23s)
=== RUN   TestListProfilerExecutionDetails/list_execution_detail_files
    jobs_profiler_execution_details_test.go:421: 
        	Error Trace:	pkg/sql/jobs_profiler_execution_details_test.go:421
        	            				pkg/testutils/soon.go:71
        	            				pkg/util/retry/retry.go:213
        	            				pkg/testutils/soon.go:77
        	            				pkg/testutils/soon.go:56
        	            				pkg/testutils/soon.go:38
        	            				pkg/sql/jobs_profiler_execution_details_test.go:415
        	Error:      	"[1/resumer-trace/20250318_182843.39~cockroach.sql.jobs.jobspb.TraceData.binpb 1/resumer-trace/20250318_182843.39~cockroach.sql.jobs.jobspb.TraceData.binpb.txt distsql.20250318_182843.12.html distsql.20250318_182843.52.html goroutines.20250318_182843.19.txt goroutines.20250318_182843.54.txt trace.20250318_182843.20.zip trace.20250318_182843.55.zip]" should have 10 item(s), but has 8
        	Test:       	TestListProfilerExecutionDetails/list_execution_detail_files
--- FAIL: TestListProfilerExecutionDetails/list_execution_detail_files (0.56s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

Jira issue: CRDB-48649
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Mar 18, 2025
@github-project-automation github-project-automation bot moved this to Triage in SQL Queries Mar 18, 2025
@cockroach-teamcity
Copy link
Member Author

sql.TestListProfilerExecutionDetails failed with artifacts on master @ ff8d2bd1b002a1d83b44b07edaa5580290ec9d05:

=== RUN   TestListProfilerExecutionDetails
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails3354553608
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:141: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    jobs_profiler_execution_details_test.go:440: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails3354553608
--- FAIL: TestListProfilerExecutionDetails (0.85s)
=== RUN   TestListProfilerExecutionDetails/list_execution_detail_files
    jobs_profiler_execution_details_test.go:421: 
        	Error Trace:	pkg/sql/jobs_profiler_execution_details_test.go:421
        	            				pkg/testutils/soon.go:71
        	            				pkg/util/retry/retry.go:213
        	            				pkg/testutils/soon.go:77
        	            				pkg/testutils/soon.go:56
        	            				pkg/testutils/soon.go:38
        	            				pkg/sql/jobs_profiler_execution_details_test.go:415
        	Error:      	"[1/resumer-trace/20250318_200810.69~cockroach.sql.jobs.jobspb.TraceData.binpb 1/resumer-trace/20250318_200810.69~cockroach.sql.jobs.jobspb.TraceData.binpb.txt distsql.20250318_200810.49.html distsql.20250318_200810.77.html goroutines.20250318_200810.51.txt goroutines.20250318_200810.78.txt trace.20250318_200810.52.zip trace.20250318_200810.79.zip]" should have 10 item(s), but has 8
        	Test:       	TestListProfilerExecutionDetails/list_execution_detail_files
--- FAIL: TestListProfilerExecutionDetails/list_execution_detail_files (0.38s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@yuzefovich yuzefovich added T-db-server and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-sql-queries SQL Queries Team labels Mar 19, 2025
@yuzefovich yuzefovich removed this from SQL Queries Mar 19, 2025
@shubhamdhama shubhamdhama mentioned this issue Mar 19, 2025
Merged
@cockroach-teamcity
Copy link
Member Author

sql.TestListProfilerExecutionDetails failed on master @ 94db60946a203659fd7a0939439fd1e2fba32b64:

=== RUN   TestListProfilerExecutionDetails
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestListProfilerExecutionDetails2547715028
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:141: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    jobs_profiler_execution_details_test.go:440: -- test log scope end --
test logs left over in: outputs.zip/logTestListProfilerExecutionDetails2547715028
--- FAIL: TestListProfilerExecutionDetails (0.51s)
=== RUN   TestListProfilerExecutionDetails/list_execution_detail_files
    jobs_profiler_execution_details_test.go:402: 
        	Error Trace:	pkg/sql/jobs_profiler_execution_details_test.go:402
        	            				pkg/testutils/soon.go:71
        	            				pkg/util/retry/retry.go:213
        	            				pkg/testutils/soon.go:77
        	            				pkg/testutils/soon.go:56
        	            				pkg/testutils/soon.go:38
        	            				pkg/sql/jobs_profiler_execution_details_test.go:396
        	Error:      	"[distsql.20250319_055549.34.html goroutines.20250319_055549.36.txt trace.20250319_055549.37.zip]" should have 5 item(s), but has 3
        	Test:       	TestListProfilerExecutionDetails/list_execution_detail_files
--- FAIL: TestListProfilerExecutionDetails/list_execution_detail_files (0.20s)

Parameters:

  • attempt=1
  • run=5
  • shard=11
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql.TestListProfilerExecutionDetails failed with artifacts on master @ 07717228b09021b5a3cea4fd33e4b39dd8e5cf9f:

=== RUN   TestListProfilerExecutionDetails
    test_log_scope.go:165: test logs captured to: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails4262569852
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:141: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    jobs_profiler_execution_details_test.go:440: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/f4d1e5a362e4384d18c9c26e2defb957/logTestListProfilerExecutionDetails4262569852
--- FAIL: TestListProfilerExecutionDetails (0.81s)
=== RUN   TestListProfilerExecutionDetails/list_execution_detail_files
    jobs_profiler_execution_details_test.go:402: 
        	Error Trace:	pkg/sql/jobs_profiler_execution_details_test.go:402
        	            				pkg/testutils/soon.go:71
        	            				pkg/util/retry/retry.go:213
        	            				pkg/testutils/soon.go:77
        	            				pkg/testutils/soon.go:56
        	            				pkg/testutils/soon.go:38
        	            				pkg/sql/jobs_profiler_execution_details_test.go:396
        	Error:      	"[distsql.20250319_105357.16.html goroutines.20250319_105357.21.txt trace.20250319_105357.22.zip]" should have 5 item(s), but has 3
        	Test:       	TestListProfilerExecutionDetails/list_execution_detail_files
--- FAIL: TestListProfilerExecutionDetails/list_execution_detail_files (0.31s)
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@cockroach-teamcity
Copy link
Member Author

sql.TestListProfilerExecutionDetails failed on master @ 3227e31cc49650fae510626b79a2e93614195bc6:

=== RUN   TestListProfilerExecutionDetails
    test_log_scope.go:165: test logs captured to: outputs.zip/logTestListProfilerExecutionDetails4284794969
    test_log_scope.go:76: use -show-logs to present logs inline
    test_server_shim.go:141: cluster virtualization disabled in global scope due to issue: #76378 (expected label: C-bug)
    jobs_profiler_execution_details_test.go:440: -- test log scope end --
test logs left over in: outputs.zip/logTestListProfilerExecutionDetails4284794969
--- FAIL: TestListProfilerExecutionDetails (5.33s)
=== RUN   TestListProfilerExecutionDetails/list_execution_detail_files
    jobs_profiler_execution_details_test.go:421: 
        	Error Trace:	pkg/sql/jobs_profiler_execution_details_test.go:421
        	            				pkg/testutils/soon.go:71
        	            				pkg/util/retry/retry.go:213
        	            				pkg/testutils/soon.go:77
        	            				pkg/testutils/soon.go:56
        	            				pkg/testutils/soon.go:38
        	            				pkg/sql/jobs_profiler_execution_details_test.go:415
        	Error:      	"[1/resumer-trace/20250319_121201.12~cockroach.sql.jobs.jobspb.TraceData.binpb 1/resumer-trace/20250319_121201.12~cockroach.sql.jobs.jobspb.TraceData.binpb.txt distsql.20250319_121200.10.html distsql.20250319_121201.52.html goroutines.20250319_121200.17.txt goroutines.20250319_121201.61.txt trace.20250319_121200.22.zip trace.20250319_121201.66.zip]" should have 10 item(s), but has 8
        	Test:       	TestListProfilerExecutionDetails/list_execution_detail_files
--- FAIL: TestListProfilerExecutionDetails/list_execution_detail_files (2.08s)

Parameters:

  • attempt=1
  • race=true
  • run=1
  • shard=11
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

@asg0451
Copy link
Contributor

asg0451 commented Mar 19, 2025

i've seen this a few times on my branch: https://github.com/cockroachdb/cockroach/actions/runs/13948951419/job/39043073365?pr=143102

craig bot pushed a commit that referenced this issue Mar 19, 2025
@shubhamdhama
Merge #143113
7c38217 
143113: sql: fix TestListProfilerExecutionDetails r=yuzefovich a=shubhamdhama

In #142391, a bug was introduced in the test where `testutils.SucceedSoon`'s closure used `require.Len` instead of returning an error, causing the test to fail if slice length doesn't match without retrying. This assertion has been reverted to the `if` statement that returns an error instead.

Fixes: #143082
Release note: none
Epic: none

Co-authored-by: Shubham Dhama <[email protected]>
@shubhamdhama
Copy link
Contributor

@asg0451 , the fix is ready and should merge shortly.

@craig craig bot closed this as completed in e02ff28 Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhamdhama shubhamdhama

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-db-server target-release-25.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: fix TestListProfilerExecutionDetails shubhamdhama/cockroach
4 participants
@asg0451 @yuzefovich @cockroach-teamcity @shubhamdhama