test: Invert "no crashkernel= by default" expectation in kdump test; fix testCPUSecurityMitigationsEnable on fedora-39 #19254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Fedora 39 now has a default crashkernel= kernel option, so that kdump.service can start by default. Now only old Fedoras are left, so invert the condition to become simpler and eventually empty.
tomasmatus
previously approved these changes
Aug 29, 2023
…sEnable Fedora 39's kernel-install command has an additional magic check that requires the file to be at least two bytes long.
martinpitt
changed the title
|
@tomasmatus : I added another simple commit to fix another test . Let's share the bots run. |
jelly
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 39 now has a default crashkernel= kernel option, so that
kdump.service can start by default. Now only old Fedoras are left, so
invert the condition to become simpler and eventually empty.
This blocks cockpit-project/bots#5171 . I locally validated that TestKdump.testBasic works against fedora-39 with this fix, but as there are lots of other failures, I don't want to trigger a fedora-39 run here. I'll do that in the bots PR.