Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository #7421

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Feb 11, 2025

Image refresh for fedora-42-boot and fedora-42-anaconda-payload

  • image-refresh fedora-42-boot
  • image-refresh fedora-42-anaconda-payload

@KKoukiou KKoukiou added the bot label Feb 11, 2025
@cockpituous cockpituous changed the title images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository WIP: 10213be388cb: [no-test] images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository Feb 11, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 10213be388cb: [no-test] images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository Feb 11, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository WIP: 80dc39fea1dc: [no-test] images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository Feb 11, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 80dc39fea1dc: [no-test] images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository images: add fedora-42-boot and fedora-42-anaconda-payload for anaconda-webui repository Feb 11, 2025
lib/testmap.py Outdated
@@ -228,6 +228,8 @@ def contexts(image: str, *scenarios: Iterable[str], repo: str | None = None) ->
],
'_manual': [
'fedora-eln-boot',
*contexts('fedora-42-boot', ANACONDA_SCENARIOS),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you actually test these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am testing here: rhinstaller/anaconda-webui#631

Does not work yet. Therefore the manual trigger, when it passes in CI i will convert to automatic.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is that you flagged it for testing on image updates...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes. ok let me try to fix the tests today before merging.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for getting the tests green first!

@allisonkarlitskaya allisonkarlitskaya merged commit ab517ac into cockpit-project:main Feb 12, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants