Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: install tuned as cockpit dependency #7407

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

jelly
Copy link
Member

@jelly jelly commented Feb 7, 2025

  • image-refresh arch

@cockpituous cockpituous changed the title images: install tuned as cockpit dependency WIP: 777f99ab5afa: [no-test] images: install tuned as cockpit dependency Feb 7, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 777f99ab5afa: [no-test] images: install tuned as cockpit dependency images: install tuned as cockpit dependency Feb 7, 2025
@cockpituous
Copy link
Contributor

@jelly
Copy link
Member Author

jelly commented Feb 7, 2025

Triggered a tuned test run against this image here cockpit-project/cockpit#21597

Forgot about the context.. so it runs the full suite..

martinpitt
martinpitt previously approved these changes Feb 7, 2025
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 → 👍

@jelly
Copy link
Member Author

jelly commented Feb 7, 2025

Seems we have a regression in crun:

  crun (1.19.1-2 -> 1.20-1)

@martinpitt
Copy link
Member

retrying, hopefully flake, possibly behaviour change

@martinpitt
Copy link
Member

Although initially it doesn't look like a flake -- the criu log says

(04.872747) Error (criu/vdso.c:381): vdso: Unexpected rt vDSO area bounds
(04.872753) Error (criu/vdso.c:613): vdso: Failed to fill self vdso symtable
(04.872759) Error (criu/kerndat.c:1906): kerndat_vdso_fill_symtable failed when initializing kerndat.

This is exactly https://bugzilla.redhat.com/show_bug.cgi?id=2328985 aka #7145 - we may have to reopen that naughty and revive the pattern.

@martinpitt martinpitt dismissed their stale review February 7, 2025 18:26

needs naughty

@jelly
Copy link
Member Author

jelly commented Feb 7, 2025

We recently updated to 6.13 so this makes sense

@jelly
Copy link
Member Author

jelly commented Feb 7, 2025

Just pushed a fixed criu to Arch, I'll refresh this again so I don't have to naughty :-)

@cockpituous cockpituous changed the title images: install tuned as cockpit dependency WIP: 5fee503ab876: [no-test] images: install tuned as cockpit dependency Feb 8, 2025
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 5fee503ab876: [no-test] images: install tuned as cockpit dependency images: install tuned as cockpit dependency Feb 8, 2025
@cockpituous
Copy link
Contributor

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! We need to fix that new ruff error, but that doesn't have to block this PR.

@martinpitt martinpitt merged commit 63ca345 into cockpit-project:main Feb 8, 2025
11 of 12 checks passed
@martinpitt
Copy link
Member

ruff fixed in #7409 , I landed this with a hammer.

@jelly jelly deleted the arch-tuned branch February 10, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants