test-failure-policy: Restrict GitHub post to the last 30 lines #7169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub comments are limited to 65.000 characters. But some test outputs are larger than that, e.g. when they contain VM console dumps. We also don't really need posting the full log to the naughty, it just needs to be enough to identify the failure. Thus restrict the comment to the last 30 lines of the output, which contain the traceback or unexpected message. This avoids "422 Unprocessable Entity" errors and thus failure to track the ongoing presence of a naughty. Closes #7166
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub comments are limited to 65.000 characters. But some test outputs are larger than that, e.g. when they contain VM console dumps. We also don't really need posting the full log to the naughty, it just needs to be enough to identify the failure.
Thus restrict the comment to the last 30 lines of the output, which contain the traceback or unexpected message.
This avoids "422 Unprocessable Entity" errors and thus failure to track the ongoing presence of a naughty.
Closes #7166
PR #7166 claims that #6769 is obsolete, but it really isn't. See #7166 (review) . I tested this locally with my token, and it now successfully posted a comment.