Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-anaconda-payload: provide an RPM instead of tarball #6801

Closed
wants to merge 2 commits into from

Conversation

KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Aug 27, 2024

Image refresh for fedora-rawhide-anaconda-payload

  • image-refresh fedora-rawhide-anaconda-payload

The RPM is better usable by anaconda CI as it will install the payload through interactive defaults file.

@KKoukiou KKoukiou added the bot label Aug 27, 2024
@KKoukiou KKoukiou changed the title create-anaconda-paylod: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 27, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 06cf9146a6e8: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 27, 2024
@martinpitt
Copy link
Member

@KKoukiou FYI, it must look like this, no extra ::

 * [ ] image-refresh fedora-rawhide-anaconda-payload

You previously had * [ ]: image-refresh. (I fixed it)

@cockpituous cockpituous changed the title WIP: 06cf9146a6e8: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 27, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: ef7479ed8096: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: ef7479ed8096: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 69cc2cbba2c8: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@KKoukiou KKoukiou changed the title WIP: 69cc2cbba2c8: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 1e8698dd183a: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 1e8698dd183a: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@KKoukiou KKoukiou force-pushed the build-payload-rpm branch 2 times, most recently from 9a0a023 to 3deb967 Compare August 28, 2024 11:35
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 4473acf3796e: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 4473acf3796e: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 28, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: d084231643da: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 29, 2024
@cockpit-project cockpit-project deleted a comment from cockpituous Aug 30, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: bc79ca77f497: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 30, 2024
@martinpitt
Copy link
Member

cockpituous test still failed. This isn't for you @KKoukiou, please ignore (it's not a required test). In the meantime, I broke the script move out to PR #6811 so that it doesn't get in the way here. I triggered the a-webui tests. They are red (no surprise), but you have a PR to test an update against now.

Copy link
Contributor Author

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

martinpitt
martinpitt previously approved these changes Aug 30, 2024
Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now, so my approval is mostly to retract my previous 👎. But I suggest waiting for @adamkankovsky or other installer team member to review this.

(cockpituous test still runs because image-create changed. But I think it's ok to ignore the failure, it's not clear why it times out)

@KKoukiou
Copy link
Contributor Author

KKoukiou commented Aug 30, 2024

There is something wrong with the tar file in this payload PR - although it's not supposed to have changed how we create it.

I see when i try to untar it:

gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now

Ok I think it;'s because by mistake when renaming the tar file - I did s/tar.gz/tar.xz

@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 91474280bda4: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 30, 2024
@KKoukiou KKoukiou added bot and removed bot labels Aug 30, 2024
@KKoukiou KKoukiou changed the title WIP: 91474280bda4: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 30, 2024
@KKoukiou KKoukiou added bot and removed bot labels Aug 30, 2024
@cockpituous cockpituous changed the title create-anaconda-payload: provide an RPM instead of tarball WIP: 34875d07b9df: [no-test] create-anaconda-payload: provide an RPM instead of tarball Aug 30, 2024
@cockpituous
Copy link
Contributor

@cockpituous cockpituous changed the title WIP: 34875d07b9df: [no-test] create-anaconda-payload: provide an RPM instead of tarball create-anaconda-payload: provide an RPM instead of tarball Aug 30, 2024
KKoukiou and others added 2 commits September 1, 2024 17:12
The RPM is better usable by anaconda CI as it will install the payload
through interactive defaults file.
@KKoukiou
Copy link
Contributor Author

KKoukiou commented Sep 3, 2024

After discussion with other team members - this ended up being suboptimal solution.

Some summary background:
stage2 image has to be loaded to RAM with this - this is very memory intense requiring the test VMs to be bumped to 5GB at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants