-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create-anaconda-payload: provide an RPM instead of tarball #6801
Conversation
@KKoukiou FYI, it must look like this, no extra
You previously had |
acb51d2
to
40140be
Compare
image-refresh fedora-rawhide-anaconda-payload done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-anaconda-payload-20240828-090223 |
40140be
to
397c594
Compare
397c594
to
e08f49c
Compare
image-refresh fedora-rawhide-anaconda-payload done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-anaconda-payload-20240828-101940 |
9a0a023
to
3deb967
Compare
image-refresh fedora-rawhide-anaconda-payload done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-anaconda-payload-20240828-114730 |
3deb967
to
419330f
Compare
419330f
to
f1fe01c
Compare
image-refresh fedora-rawhide-anaconda-payload done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-anaconda-payload-20240830-022007 |
cockpituous test still failed. This isn't for you @KKoukiou, please ignore (it's not a required test). In the meantime, I broke the script move out to PR #6811 so that it doesn't get in the way here. I triggered the a-webui tests. They are red (no surprise), but you have a PR to test an update against now. |
63bd891
to
ec2facd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @martinpitt
Tests ran here: rhinstaller/anaconda-webui#421
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM now, so my approval is mostly to retract my previous 👎. But I suggest waiting for @adamkankovsky or other installer team member to review this.
(cockpituous test still runs because image-create changed. But I think it's ok to ignore the failure, it's not clear why it times out)
There is something wrong with the tar file in this payload PR - although it's not supposed to have changed how we create it. I see when i try to untar it:
Ok I think it;'s because by mistake when renaming the tar file - I did s/tar.gz/tar.xz |
ec2facd
to
d266327
Compare
image-refresh fedora-rawhide-anaconda-payload done: https://github.com/cockpit-project/bots/commits/image-refresh-fedora-rawhide-anaconda-payload-20240830-110546 |
d266327
to
f9ce03d
Compare
The RPM is better usable by anaconda CI as it will install the payload through interactive defaults file.
f9ce03d
to
7aae9d2
Compare
After discussion with other team members - this ended up being suboptimal solution. Some summary background: |
Image refresh for fedora-rawhide-anaconda-payload
The RPM is better usable by anaconda CI as it will install the payload through interactive defaults file.