feat: support retrying #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a parameter `retries` to methods `list` and `list_all`, backed by `urllib3.util.Retry` and `requests.adapters.HTTPAdapter`.
|
If you are part of the cms-dqm-coreTeam e-group you can find the SECRET_KEY mentioned in the documentation from any api-client application in CERN's Applications Portal. DM me on Mattermost if you are not a member, so I can create an api client id/secret for you. |
|
@gabrielmscampos Thank you for helping out! I just sent you a direct message on Mattermost a minute ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a parameter
retriesto methodsDials.listandDials.list_all, backed byurllib3.util.Retryandrequests.adapters.HTTPAdapter.Long downloads are prone to network issues, which can be mitigated by adding retrying functionality. This PR forwards the
max_retriesparameter ofHTTPAdapterasretriestoDials.listandDials.list_alland provides the retrying functionality without additional dependencies.Progress
I'm testing the functionality by downloading 1D histograms of four MEs from
/JetMET0/Run2024D-PromptReco-v1/DQMIO.How do I add and run the tests inside the source tree?Do you think I should also update the documentation?Update: I now see the instructions in the README.md.