New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit: Fix ModAP calculation for negative AP_MODS #730

Open

insunaa wants to merge 1 commit into cmangos:master from insunaa:fix_modap_calc

Contributor

insunaa commented Feb 27, 2025

🍰 Pullrequest

This PR fixes negative AP Mods calculating with uint16-overflow values

Issues

fixes 🐛 [Bug Report] [TBC] Attack Power mods with negative value (debuff) cause zero total Attack Power for Player issues#3872

How2Test

check your AP in character window
get a baseline average of your damage output per hit
use .aura 27551
check your AP in character window
get a second average of your damage output per hit

Todo / Checklist

None


          Unit: Fix ModAP calculation for negative AP_MODS

9c0d911

Co-authored-by: CyberBarr
Co-authored-by: insunaa <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet