Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set DNS ALIAS instead of CNAME. #144

Closed
wants to merge 2 commits into from
Closed

Set DNS ALIAS instead of CNAME. #144

wants to merge 2 commits into from

Conversation

razorsedge
Copy link
Contributor

@razorsedge razorsedge commented Sep 17, 2020 •
edited
Loading

what

  • We are switching from using DNS CNAMEs to using AWS DNS ALIAS which produces 'A' resource records.
  • Swapping module cloudposse/terraform-aws-route53-alias for module cloudposse/terraform-aws-route53-alias.
  • Supporting the creation of IPv6 AAAA records as well.

why

  • This is best practice for Beanstalk DNS configuration.
  • A single DNS request will occur to retrieve the A/AAAA instead of two requests: one to process the CNAME and the other to process the CNAME's target.
  • It allows the use of TXT, CAA, or other resource records for the same domain name.

references

@razorsedge razorsedge requested a review from a team as a code owner September 17, 2020 20:33
@razorsedge razorsedge requested review from jamengual and RothAndrew and removed request for a team September 17, 2020 20:33
@mergify
Copy link
Contributor

mergify bot commented Dec 27, 2020

This pull request is now in conflict. Could you fix it @razorsedge? 🙏

@razorsedge
Set DNS ALIAS instead of CNAME.
03ffdd0 
Use terraform-aws-route53-alias instead of
terraform-aws-route53-cluster-hostname in order to create a Route53
ALIAS instead of a CNAME.
Closes GH#134
@razorsedge razorsedge requested review from a team as code owners January 15, 2021 16:51
@mergify
Copy link
Contributor

mergify bot commented Feb 3, 2021

This pull request is now in conflict. Could you fix it @razorsedge? 🙏

@razorsedge
Copy link
Contributor Author

Let me know when this PR will actually be reviewed and I will update it to fix any merge conflicts.

@aknysh
Copy link
Member

aknysh commented Dec 31, 2021

@razorsedge please resolve the conflicts and please make it backwards compatible

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d hans-d closed this Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual

@RothAndrew RothAndrew Awaiting requested review from RothAndrew

Assignees
No one assigned
Labels
stale This PR has gone stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use terraform-aws-route53-alias instead of terraform-aws-route53-cluster-hostname
3 participants
@razorsedge @aknysh @hans-d