Update dependency hpcloud/tail to the successor nxadm/tail #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
Update dependency hpcloud/tail to the successor nxadm/tail (fork). hpcloud/tail is not longer maintained.
An explanation of the use cases your change solves
We currently face some issues on our live landscapes. We see that many logs are missing after the logrotation (see issue The logs forwarding by syslog got lost syslog-release#64).
@b1tamara and I debugged the problem and we are sure that something goes wrong in the hpcloud/tail library.
We saw that hpcloud/tail is not longer maintained and the successor is nxadm/tail. Many issues are solved in the meantime in this fork. We hope that this will maybe also solve our problems.
Instructions to functionally test the behavior change using operator interfaces (BOSH manifest, logs, curl, and metrics)
Logs should be still forwarded.
Expected result after the change
Fix issues with logrotation i.e. Overview of reviewed/fixed/applied issues/PRs of the abandoned upstream (fixed on nxadm/tail) nxadm/tail#6
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
master
branchI have run all the unit tests using
scripts/test
from blackbox.