feat: add configurable retries with exponential backoff #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrmp
force-pushed
the
connection-max-retries
branch
from
0b74782
to
f7b36a2
Compare
ctlong
reviewed
Apr 24, 2024
- blackbox now exits when it runs out of retries - default behavior does not change, configure max_retries to enable On windows blackbox was preventing log rotation when configured with invalid syslog credentials as it was locking the file while trying to endlessly reconnect. This change makes it so that blackbox exits which unlocks the file and indicates that the config is invalid. Signed-off-by: Carson Long <[email protected]> Signed-off-by: Rebecca Roberts <[email protected]> Signed-off-by: Andrew Crump <[email protected]>
acrmp
force-pushed
the
connection-max-retries
branch
from
f7b36a2
to
9674b24
Compare
ctlong
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On windows blackbox was preventing log rotation when configured with invalid syslog credentials as it was locking the file while trying to endlessly reconnect. This change makes it so that blackbox exits which unlocks the file and indicates that the config is invalid.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack