Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add e2e tests of the build+preview use case #8384

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: add e2e tests of the build+preview use case #8384

wants to merge 1 commit into from

Conversation

petebacondarwin
Copy link
Contributor

@petebacondarwin petebacondarwin commented Mar 6, 2025 •
edited
Loading

DEVX-1728: adds missing tests.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: adding tests elsewhere
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: just adding tests

@petebacondarwin petebacondarwin requested review from a team as code owners March 6, 2025 17:55
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0a8101e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-wrangler-8384

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8384/npm-package-wrangler-8384

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-wrangler-8384 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-workers-bindings-extension-8384 -O ./cloudflare-workers-bindings-extension.0.0.0-v613f99d4d.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v613f99d4d.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-create-cloudflare-8384 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-kv-asset-handler-8384

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-miniflare-8384

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-pages-shared-8384

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-unenv-preset-8384

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-vite-plugin-8384

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-vitest-pool-workers-8384

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-workers-editor-shared-8384

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-workers-shared-8384

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13760972645/npm-package-cloudflare-workflows-shared-8384

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250224.0
workerd 1.20250224.0 1.20250224.0
workerd --version 1.20250224.0 2025-02-24

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin force-pushed the pbd/vite-plugin/add-build-e2e-tests branch from e10c0ac to 0a8101e Compare March 10, 2025 09:15
jamesopstad
jamesopstad reviewed Mar 10, 2025
View reviewed changes
packages/vite-plugin-cloudflare/e2e/basic.test.ts
Comment on lines +19 to +20
const command = pm === "npm" ? `npx` : pm;
runCommand(`${command} vite build`, projectPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to wrap this in a viteBuild function so we have one for dev, build and preview.

packages/vite-plugin-cloudflare/e2e/helpers.ts
const processes: ChildProcess[] = [];
await use((projectPath) => {
debuglog("starting `vite preview` for " + projectPath);
const proc = childProcess.exec(`pnpm exec vite preview`, {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using the correct package manager rather than pnpm here?

packages/vite-plugin-cloudflare/e2e/helpers.ts
`Wrapped process logs (${proc.spawnfile} ${proc.spawnargs.join(" ")}):`
);
console.log(wrappedProc.stdout);
console.log(wrappedProc.stderr);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use console.error here?

Suggested change
console.log(wrappedProc.stderr);
console.error(wrappedProc.stderr);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesopstad jamesopstad jamesopstad left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-changeset-required
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petebacondarwin @jamesopstad