fix(wrangler): Error if Workers + Assets are run in remote mode #6778
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Workers + Assets are currently supported only in local mode. We should throw an error if users attempt to use Workers with assets in remote mode.
🦋 Changeset detectedLatest commit: 73083e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-wrangler-6778You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6778/npm-package-wrangler-6778Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-wrangler-6778 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-create-cloudflare-6778 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-cloudflare-kv-asset-handler-6778npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-miniflare-6778npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-cloudflare-pages-shared-6778npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-cloudflare-vitest-pool-workers-6778npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-cloudflare-workers-editor-shared-6778npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10947168326/npm-package-cloudflare-workers-shared-6778Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
GregBrimble
approved these changes
Sep 19, 2024
| (args as StartDevOptions).remote | ||
| ) { | ||
| throw new UserError( | ||
| "Cannot use Experimental Assets in remote mode. Workers with assets are only supported in local mode." |
There was a problem hiding this comment.
Suggested change
| "Cannot use Experimental Assets in remote mode. Workers with assets are only supported in local mode." | |
| "Cannot use Experimental Assets in remote mode. Workers with assets are only supported in local mode. Please use `wrangler dev`." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Workers + Assets are currently supported only in local mode. We should throw an error if users attempt to use Workers with assets in remote mode.
Fixes WC-2743
Author has addressed the following