refactor: use require.resolve
and remove resolve
dependency
#6752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes N/A
It looks like we can simplify the resolve using
require.resolve
, similar to how other parts of the codebase that also does so:workers-sdk/packages/vitest-pool-workers/src/pool/module-fallback.ts
Line 292 in 0deb42b
workers-sdk/packages/wrangler/src/deployment-bundle/bundle.ts
Lines 332 to 337 in 0deb42b
This allows the package to drop the
resolve
dependency, which isn't used anywhere else in thewrangler
prod dependency graph.Author has addressed the following