Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip Add WORKERS_CI environment variable to wrangler interactivity check #6740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cmsparks
Copy link

@cmsparks cmsparks commented Sep 17, 2024

What this PR solves / how to test

wip

Fixes BANDA-406.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

@cmsparks cmsparks requested a review from a team as a code owner September 17, 2024 19:17
Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 63c3c69

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-wrangler-6740

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6740/npm-package-wrangler-6740

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-wrangler-6740 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-create-cloudflare-6740 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-kv-asset-handler-6740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-miniflare-6740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-pages-shared-6740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-vitest-pool-workers-6740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-workers-editor-shared-6740
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-workers-shared-6740

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.2
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -6,7 +6,7 @@ import { CI } from "./is-ci";
* or you're piping values from / to another process, etc
*/
export default function isInteractive(): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many CLIs I've used respect CI=1 unless FORCE_COLOR=1 - I'm surprised we don't do that in wrangler

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually do, it just uses this external is-ci library (which imports the ci-info library): https://github.com/watson/ci-info/blob/master/index.js#L60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants