-
Notifications
You must be signed in to change notification settings - Fork 665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip Add WORKERS_CI environment variable to wrangler interactivity check #6740
base: main
Are you sure you want to change the base?
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-wrangler-6740 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6740/npm-package-wrangler-6740 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-wrangler-6740 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-create-cloudflare-6740 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-kv-asset-handler-6740 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-miniflare-6740 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-pages-shared-6740 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-vitest-pool-workers-6740 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-workers-editor-shared-6740 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10909589077/npm-package-cloudflare-workers-shared-6740 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -6,7 +6,7 @@ import { CI } from "./is-ci"; | |||
* or you're piping values from / to another process, etc | |||
*/ | |||
export default function isInteractive(): boolean { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many CLIs I've used respect CI=1 unless FORCE_COLOR=1 - I'm surprised we don't do that in wrangler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually do, it just uses this external is-ci library (which imports the ci-info library): https://github.com/watson/ci-info/blob/master/index.js#L60
What this PR solves / how to test
wip
Fixes BANDA-406.
Author has addressed the following