Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: create fixture that tests node compatibility with --x-include-runtime #6723

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyjessop
Copy link
Contributor

What this PR solves / how to test

Fixes #000.

This PR adds a test to ensure that Workers generated types are compatible with projects that have Node.js types installed.

cloudflare/workerd#1298

The type-generation Worker in workerd has been updated so that the Request, Response, and WebSocket interfaces are now compatible.

In order to test this, a fixture has been created containing a Worker with examples of code that would fail without the new interfaces.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: doesn't impact any existing modules
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this effectively a bug fix

Copy link

changeset-bot bot commented Sep 16, 2024

⚠️ No Changeset found

Latest commit: 50361ea

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-wrangler-6723

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6723/npm-package-wrangler-6723

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-wrangler-6723 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-create-cloudflare-6723 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-cloudflare-kv-asset-handler-6723
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-miniflare-6723
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-cloudflare-pages-shared-6723
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-cloudflare-vitest-pool-workers-6723
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-cloudflare-workers-editor-shared-6723
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10882764519/npm-package-cloudflare-workers-shared-6723

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.1
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant