Skip to content

Code owners: Add workers-runtime team back to src/cloudflare #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fhanau
Copy link
Contributor

@fhanau fhanau commented Apr 8, 2025

As suggested at #3876 (comment) – some src/cloudflare changes are not relevant to the Runtime team. Hopefully the wrangler team will still get assigned preferentially based on being listed first?

@fhanau fhanau requested review from danlapid and penalosa April 8, 2025 16:18
@fhanau fhanau requested review from a team as code owners April 8, 2025 16:18
@fhanau fhanau requested a review from hoodmane April 8, 2025 16:18
Copy link
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be more specific with which files we need ownership of if we have to, or just wait for their review, it's not that bad.

We would get auto assigned because our team is configured to auto assigned while theirs isn't.

@penalosa
Copy link
Contributor

penalosa commented Apr 9, 2025

@danlapid I don't think any src/cloudflare changes are really relevant to the Wrangler team—are there specific sections you're thinking of? AFAIK these contain code that's part of workerd and are unrelated to type definitions

@danlapid
Copy link
Collaborator

danlapid commented Apr 9, 2025

@danlapid I don't think any src/cloudflare changes are really relevant to the Wrangler team—are there specific sections you're thinking of? AFAIK these contain code that's part of workerd and are unrelated to type definitions

All of the types in https://github.com/cloudflare/workerd/tree/main/src/cloudflare/internal are better off reviewed by the wrangler team imo.
The runtime team can't really do a good job reviewing those.

@penalosa
Copy link
Contributor

penalosa commented Apr 9, 2025

@danlapid those types aren't exposed to users though (the ones in types/defines are, which admittedly are usually basically a duplicate, I think).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants