Skip to content

Split up several Bazel targets #3838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

joshthoward
Copy link
Contributor

No description provided.

@joshthoward joshthoward requested review from a team as code owners March 31, 2025 01:17
@joshthoward joshthoward requested review from jasnell and fhanau March 31, 2025 01:17
@joshthoward joshthoward changed the title Joshthoward/improve build Split up several Bazel targets Mar 31, 2025
@joshthoward joshthoward marked this pull request as draft March 31, 2025 14:00
@joshthoward joshthoward force-pushed the joshthoward/improve-build branch from 4ac3c71 to a506c0a Compare April 1, 2025 01:21
@joshthoward joshthoward force-pushed the joshthoward/improve-build branch from a506c0a to aacd9e3 Compare April 1, 2025 04:22
@fhanau
Copy link
Contributor

fhanau commented Apr 1, 2025

Ready to review this when out of draft stage – also note that this will need a downstream PR with non-trivial changes as targets like @workerd//src/workerd/util disappear.

@joshthoward
Copy link
Contributor Author

Ready to review this when out of draft stage – also note that this will need a downstream PR with non-trivial changes as targets like @workerd//src/workerd/util disappear.

@fhanau To clarify, you mean an internal PR replacing references to this target in edgeworker? That makes sense, but why would you expect that to be any less trivial than anything else I've done here?

@fhanau
Copy link
Contributor

fhanau commented Apr 1, 2025

Ready to review this when out of draft stage – also note that this will need a downstream PR with non-trivial changes as targets like @workerd//src/workerd/util disappear.

@fhanau To clarify, you mean an internal PR replacing references to this target in edgeworker? That makes sense, but why would you expect that to be any less trivial than anything else I've done here?

With non-trivial, I was referring to the effort needed/number of targets that need to be updated – need to replace the split-up dependencies, and then dependents of targets that used to use util may need to have more dependencies added to make a different part of util available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants