Add "wderrid" error IDs to opaque "internal error" exceptions #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentonv
reviewed
Feb 3, 2025
jclee
force-pushed
the
jlee/internal-error-ids
branch
from
1ef3224 to
b68407d
Compare
jclee
commented
Feb 5, 2025
justin-mp
reviewed
Feb 5, 2025
jclee
force-pushed
the
jlee/internal-error-ids
branch
from
f2d6955 to
82d3fed
Compare
|
Updated to fix https://github.com/cloudflare/workerd/compare/b68407db..82d3fed42b5f2e8b29889426d12fd4acb766d834 |
kentonv
reviewed
Feb 6, 2025
justin-mp
approved these changes
Feb 6, 2025
...to make it easier to correlate internal error logs with user error reports.
kentonv
approved these changes
Feb 7, 2025
...and only render internal error reference IDs in user-facing "internal error" exceptions if autogate is enabled.
jclee
force-pushed
the
jlee/internal-error-ids
branch
from
82d3fed to
51123f6
Compare
|
Put new behavior behind autogate (51123f6), rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to make it easier to correlate internal error logs with user error reports.