New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POC for basic web platform test integration #2585

Merged

npaun merged 7 commits into main from jsnell/wip-wpt

Oct 22, 2024

Member

jasnell commented Aug 22, 2024 •

edited

Loading

This is just a proof of concept to start working through what is necessary to integrate web platform tests into wd-tests.

There are some limitations to this approach...

All module imports are evaluated outside of an IoContext, even if they are dynamic imports. This means that no test can schedule any actual i/o. Any test that depends on setTimeout, for instance, won't work with this pattern. This also means that none of the fetch tests would work under this pattern (EventSource, timers, Web Sockets, etc, all wouldn't be possible with this approach)
The test harness messes with the global scope. Ideally we'd be running these things in something like a ShadowRealm ... otherwise there's always a possibility of the harness conflicting with the global scope, tho that is unlikely in practice

jasnell requested review from mikea, IgorMinar, anonrig, kentonv, npaun and fhanau

August 22, 2024 00:02

jasnell force-pushed the jsnell/wip-wpt branch from 2a42bf6 to de0330d Compare

August 22, 2024 00:05

jasnell commented

View reviewed changes

build/BUILD.wpt Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/BUILD.bazel Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/url-test.js Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/url-test.js Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/url-test.wd-test Outdated Show resolved Hide resolved

jasnell force-pushed the jsnell/wip-wpt branch 2 times, most recently from 7c954b5 to e5803d7 Compare

August 22, 2024 19:07

anonrig reviewed

View reviewed changes

src/workerd/api/wpt/url-test.js Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/BUILD.bazel Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/generate-tests.bzl Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

src/workerd/api/wpt/url-test.js Show resolved Hide resolved

jasnell commented

View reviewed changes

src/wpt/harness.js Show resolved Hide resolved

anonrig force-pushed the jsnell/wip-wpt branch 2 times, most recently from 9d9af02 to 37c95b4 Compare

September 10, 2024 15:41

anonrig mentioned this pull request

add bazel config file web-platform-tests/wpt#48084

Open

npaun and others added 6 commits

October 17, 2024 07:16


          POC for basic web platform test integration

658104d


          automatically create wd-test files

8e0aa22


          attempt to generate files

37e8864


          auto generate dates

8fdaa29


          use native.glob fork of wpt

2f8d316


          Do not override build file

275654d

npaun marked this pull request as ready for review

October 18, 2024 16:43

npaun requested a review from a team as a code owner

October 18, 2024 16:43

npaun requested a review from a team as a code owner

October 18, 2024 16:43

Member

npaun commented Oct 18, 2024

@jasnell @anonrig I think this might be almost ready to merge. I think I found a pretty elegant bazel solution.

npaun force-pushed the jsnell/wip-wpt branch 4 times, most recently from 83f80f2 to 26ec3fc Compare

October 18, 2024 16:56

anonrig reviewed

View reviewed changes

build/BUILD.wpt Outdated Show resolved Hide resolved

build/wpt_test.bzl Outdated Show resolved Hide resolved

npaun force-pushed the jsnell/wip-wpt branch 2 times, most recently from bbc4317 to 8c9251a Compare

October 18, 2024 18:02

Member

npaun commented Oct 21, 2024

Hmm the checksum of the Github Release for WPT keeps changing...

So far for https://github.com/web-platform-tests/wpt/archive/refs/tags/merge_pr_48695.tar.gz I've seen:

sha256-Hxn/D6x6lI9ISlCQFq620sb8x9iXplVzXPV6zumX84A=
sha256-2qTT6fguxmM+8ND0AgIlysNkqRHzELEiaCqEo6Y3PrY=
sha256-W9YnJn4yn9LpOYB3oOx2aSaG88t6qqwiWDL7zsogGdc=

npaun force-pushed the jsnell/wip-wpt branch 3 times, most recently from 1318d1a to 59ce311 Compare

October 21, 2024 22:01

npaun requested a review from anonrig

October 22, 2024 14:19

npaun force-pushed the jsnell/wip-wpt branch from 59ce311 to c60b991 Compare

October 22, 2024 14:21

npaun linked an issue

that may be closed by this pull request

Web Platform Tests #2862

Open

8 tasks

jasnell commented

View reviewed changes

build/wpt_test.bzl Outdated Show resolved Hide resolved

Member Author

jasnell commented Oct 22, 2024

LGTM but I'm unable to approve the PR officially since I'm the original author

anonrig approved these changes

View reviewed changes


          Bazel test auto discovery

bb842f7

npaun force-pushed the jsnell/wip-wpt branch from c60b991 to bb842f7 Compare

October 22, 2024 17:38

npaun merged commit 98ed1ab into main

13 checks passed

npaun deleted the jsnell/wip-wpt branch

October 22, 2024 17:44

npaun mentioned this pull request

Web Platform Tests #2862

Open

8 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes

mikea Awaiting requested review from mikea

IgorMinar Awaiting requested review from IgorMinar

kentonv Awaiting requested review from kentonv

npaun Awaiting requested review from npaun

fhanau Awaiting requested review from fhanau

Labels

None yet