-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resource cloudflare_page_shield #4007
Add resource cloudflare_page_shield #4007
Conversation
@@ -276,6 +276,7 @@ func New(version string) func() *schema.Provider { | |||
"cloudflare_observatory_scheduled_test": resourceCloudflareObservatoryScheduledTest(), | |||
"cloudflare_origin_ca_certificate": resourceCloudflareOriginCACertificate(), | |||
"cloudflare_page_rule": resourceCloudflarePageRule(), | |||
"cloudflare_page_shield": resourceCloudflarePageShield(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Willing to change the name to: cloudflare_page_shield_settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should definitely rename this resource to be more specific however, we also aren't accepting more resources added to the SDKv2 so we'll need to port this into the terraform-plugin-framework
instead. we have a ratchet in place that notifies you when you try and run the acceptance test suite (acc tests won't run on PRs due to creating real resources and taking forever to run).
changelog detected ✅ |
Enabled: cloudflare.BoolPtr(false), | ||
UseCloudflareReportingEndpoint: cloudflare.BoolPtr(true), | ||
UseConnectionURLPath: cloudflare.BoolPtr(false), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Determined these based on how my zone is currently configured (and I believe we hadn't enabled Page Shield yet...)
0765064
to
ba88f36
Compare
Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the |
This PR was closed because it has been stalled for 7 days with no activity. |
Existing API: https://github.com/cloudflare/cloudflare-go/blob/8743749c8ce71e82a506005135ac90f1120fc061/page_shield.go#L12
API documentation: https://developers.cloudflare.com/api/operations/page-shield-get-settings
Adds support for managing Page Shield configuration via terraform.