Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource cloudflare_page_shield #4007

Conversation

joshuamsager
Copy link
Contributor

@@ -276,6 +276,7 @@ func New(version string) func() *schema.Provider {
"cloudflare_observatory_scheduled_test": resourceCloudflareObservatoryScheduledTest(),
"cloudflare_origin_ca_certificate": resourceCloudflareOriginCACertificate(),
"cloudflare_page_rule": resourceCloudflarePageRule(),
"cloudflare_page_shield": resourceCloudflarePageShield(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Willing to change the name to: cloudflare_page_shield_settings

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should definitely rename this resource to be more specific however, we also aren't accepting more resources added to the SDKv2 so we'll need to port this into the terraform-plugin-framework instead. we have a ratchet in place that notifies you when you try and run the acceptance test suite (acc tests won't run on PRs due to creating real resources and taking forever to run).

Copy link
Contributor

github-actions bot commented Sep 14, 2024

changelog detected ✅

Comment on lines +74 to +76
Enabled: cloudflare.BoolPtr(false),
UseCloudflareReportingEndpoint: cloudflare.BoolPtr(true),
UseConnectionURLPath: cloudflare.BoolPtr(false),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Determined these based on how my zone is currently configured (and I believe we hadn't enabled Page Shield yet...)

@jacobbednarz jacobbednarz force-pushed the add-resource_cloudflare_page_shield branch from 0765064 to ba88f36 Compare September 17, 2024 04:21
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Marking this pull request as stale due to 14 days of inactivity. This helps our maintainers find and focus on the active pull requests. If this pull request receives no comments in the next 7 days it will automatically be closed. Maintainers can also remove the lifecycle/stale label.
If this pull request was automatically closed and you feel this pull request should be reopened, we encourage creating a new pull request linking back to this one for added context. Thank you!

Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants