Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a new crate for abstracting away direct interactions with cmsgs. It currently only contains implementations for Linux, but we can add multi-platform support when required.
Tasks
syscalls
). I ended up just making the vast majority of the calls Linux-only, but ensured that quiche-server still works.Notes
MsgFlags
currently aren't supported since we don't have a use case for them, and trying to implement them was causing crate conflicts. If this is a blocker, I can add support.Testing
Unit tests exist for basic functionality, but should probably be more robust. One per syscall would be nice. I also tested with a basic
quiche-server
/quiche-client
setup on both Linux and MacOS.I plan on testing on a remote metal to double-check the GSO/GRO implementation, since that apparently doesn't work on loopback.
QUIC Interop Runner results
GSO/GRO Testing