Properly await for all futures in Future for TelemetryDriver #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nox
force-pushed
the
fix-telemetrydriver
branch
from
071b77c
to
a54bbb5
Compare
inikulin
reviewed
Nov 8, 2024
| if let Poll::Ready(res) = Pin::new(server_fut).poll(cx) { | ||
| ready_res.push(res.map_err(|err| anyhow!(err))); | ||
| if let Poll::Ready(()) = Pin::new(server_fut).poll(cx)? { | ||
| self.server_fut = None; |
There was a problem hiding this comment.
doesn't it mean we'll poll the server just once?
There was a problem hiding this comment.
No, this checks for Poll::Ready(()), so it will be polled until it's ready.
nox
force-pushed
the
fix-telemetrydriver
branch
from
a54bbb5
to
a8e7f01
Compare
nox
force-pushed
the
fix-telemetrydriver
branch
from
a8e7f01
to
0a6d3ba
Compare
cbranch
approved these changes
Nov 8, 2024
cbranch
reviewed
Nov 8, 2024
| } | ||
| } | ||
|
|
||
| let tele_futures_poll = Pin::new(&mut self.tele_futures).poll_next(cx); | ||
| ready!(Pin::new(&mut self.tele_futures).poll_next(cx)?); |
There was a problem hiding this comment.
technically we should call self.tele_futures.is_terminated() first, but FuturesUnordered would be hard to work with if you couldn't call poll_next as many times as you like
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.