adds stream create parameters: maxDurationSeconds and expiry #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
|
@jacobbednarz pinging to see if you have a chance to take a loot at this PR. I've also opened this under my personal account (instead of org) and was able to allow maintainer to make edits. Hopefully, this will be easier to review/merge. Thank you in advance! |
|
@jacobbednarz Sorry for the ping. I'm not the author of this PR), but having this feature into the SDK would be a great start to 2024! 🙏 |
|
closing to due to missing API schemas and timing out. when the service team updates these schemas, they can reopen or send over this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
stream.StreamInitiateTUSVideoUploadcurrently allows you create a video streamfor upload using TUS protocol. Due to lack of
maxDurationSeconds, the streamscreated (for
direct_user=true) results inmaxDurationSeconds= 14400whichtakes the video billing quota until the video is uploaded. This PR adds supports to
pass additional params
MaxDurationSecondsandExpiryinTUSUploadMetadatato add appropriate functionality to the newly created stream/video.
Closes #1399
Has your change been tested?
Added unit test to verify
expiryandmaxDurationSecondsmetadata values areproperly encoded. Manually tested these by making API calls to cloudflare api using
a test account and verifying these values are correctly set in newly created stream video.
Types of changes
What sort of change does your code introduce/modify?
Checklist:
and relies on stable APIs.