-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about application posture check path comparison #16923
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cloudflare-docs with Cloudflare Pages
|
ranbel
reviewed
Sep 18, 2024
src/content/docs/cloudflare-one/identity/devices/warp-client-checks/application-check.mdx
Outdated
Show resolved
Hide resolved
ranbel
approved these changes
Sep 20, 2024
fix compile errors
This can be merged now. The release containing the changes is out: https://install.appcenter.ms/orgs/cloudflare/apps/1.1.1.1-macos-1/distribution_groups/release |
elithrar
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Add note about application posture check path comparison * Revert "Add note about application posture check path comparison" This reverts commit d63d727. * Update macOS application check verify command --------- Co-authored-by: Ranbel Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
SHELP-384 exposed an issue with the WARP client, where Application type posture checks may not be working as expected under certain conditions. In brief, the issue was due to how the client compares the user-specified path in the dashboard against the path of the running process. The issue was been fixed by CLIENT-10539.
Summary
This PR adds some additional details to the note on the application check page.
This PR should NOT be merged before the new version with the fix is released (planned for the week of Nov 4th)
Documentation checklist