replace frozen crypto/pkcs12 library with software.sslmate.com/src/go-pkcs12 #1375
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with
cfssl
a bit, I've noticed that its not always possible to decode.p12
- or.pfx
-files due to the following error:While doing some research on this, I've found out, that the standard
crypto/pkcs12
-pkg is currently in a somewhat frozen state:golang/go#62375
This PR suggests replacing the (currently) frozen
crypto/pkcs12
with the drop-in-replacementhttps://github.com/SSLMate/go-pkcs12
.I also had to rework the caCertificate-Handling a bit by using
DecodeChain
instead ofDecode
, since its possible that the provided pfxData may also include the ca-certificate chain which would lead to an error when passed to a simpleDecode
.Let me know what you think.
Thanks!