Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag to not fail the revocation status when multiple CRL distribution points having same CRL. #1180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yogi1994
Copy link

@Yogi1994 Yogi1994 commented Mar 5, 2021

Problem:There are cases when there is same CRL hosted at multiple locations for high availability.
Some if the URLs(CRL Distribution points) may not be reachable. In this case, it is not required for the certificate to pass every CRL(as the CRL is same in every hosted location).
Solution: Verify at least 1 hosted location and not fail if host is not reachable.
If any of the URL is reachable and verified as not revoked then we should not reject the certificate.

@codecov-io
Copy link

codecov-io commented Mar 5, 2021

Codecov Report

Merging #1180 (b1646d8) into master (c6f04ed) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   54.66%   54.64%   -0.03%     
==========================================
  Files          77       77              
  Lines        6653     6663      +10     
==========================================
+ Hits         3637     3641       +4     
- Misses       2559     2562       +3     
- Partials      457      460       +3     
Impacted Files Coverage Δ
revoke/revoke.go 60.78% <57.14%> (-0.18%) ⬇️
csr/csr.go 78.44% <0.00%> (-0.73%) ⬇️
api/client/client.go 54.03% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6f04ed...b1646d8. Read the comment docs.

@Yogi1994
Copy link
Author

Yogi1994 commented Mar 8, 2021

@Yogi1994 Yogi1994 changed the title CRL distribution points having same CRL should not reject certificate Flag to enable CRL distribution points having same CRL should not reject certificate Mar 16, 2021
@Yogi1994 Yogi1994 changed the title Flag to enable CRL distribution points having same CRL should not reject certificate Flag to not fail the revocation status when multiple CRL distribution points having same CRL. May 12, 2021
@jovillas
Copy link

jovillas commented Feb 2, 2023

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants