Add support for Circl's signature schemes #1123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
==========================================
- Coverage 56.27% 55.90% -0.37%
==========================================
Files 77 77
Lines 7309 7364 +55
==========================================
+ Hits 4113 4117 +4
- Misses 2727 2777 +50
- Partials 469 470 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the signature schemes from Cloudflare's Circl library, such as the hybrid scheme Ed25519-Dilithium3. This is preparation to set up a secondary experimental post-quantum secure CA within Cloudflare. (See Jira ticket RTG-49 for internal context.)
cfssl relies on Go's internal
crypto/x509, which makes it impossible to add new signature schemes which are not supported by Go itself. Thus we have created a fork of Go that adds support for the signature schemes in Circl tocrypto/x509andcrypto/tls. If cfssl is built with vanilla Go, then nothing changes. If cfssl is built using our Go fork, then it will include support for the additional signature schemes. (This is controlled by thecfgobuild-tag.)This PR does not yet update cfscan as it does not support TLS 1.3 (yet). We'll add that later.